Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KB RAG v2 のオプション(フィルター)の UI 検討 #817

Merged
merged 11 commits into from
Jan 16, 2025

Conversation

tbrand
Copy link
Contributor

@tbrand tbrand commented Jan 16, 2025

変更内容の説明

  • 現状は画面右に常駐している形だが、描写領域が狭い (Expandable ではある)
    • フィルターの存在感が強すぎる
  • モーダルに逃すことで描写領域を確保

チェック項目

  • npm run lint を実行した
  • 関連するドキュメントを修正した
  • 手元の環境で動作確認済み

関連する Issue

@tbrand tbrand added the v3 label Jan 16, 2025
@tbrand tbrand marked this pull request as ready for review January 16, 2025 02:31
@@ -177,7 +187,7 @@ const InputChatContent: React.FC<Props> = (props) => {
</div>
)}
<Textarea
className={`scrollbar-thumb-gray-200 scrollbar-thin m-2 -mr-14 bg-transparent ${props.fileUpload ? 'pr-24' : 'pr-14'}`}
className={`scrollbar-thumb-gray-200 scrollbar-thin m-2 -mr-14 bg-transparent ${props.fileUpload || props.setting ? 'pr-24' : 'pr-14'}`}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fileUpload と setting が両方有効であることは現状想定されない実装

@maekawataiki
Copy link
Collaborator

LGTM です

@maekawataiki maekawataiki merged commit fb148be into v3.0.0 Jan 16, 2025
@tbrand tbrand mentioned this pull request Jan 21, 2025
3 tasks
@tbrand tbrand deleted the ragv2-option branch January 23, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants