Support full configuration of TCP keepalive probles, upgrading to v3.0.0 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use hyper stream branch 0.14.x Locally patched axum-server to make all TCP keepalive parameters available ref: git@github.com:hansonchar/axum-server.git branch: v0.4.3 commit: 839ada3 #7
vsaiki
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
aws-kms-xks-proxycurrently depends on two crates to enable TCP keep-alive, axum-server and hyper whichaxum-serverdepends upon. However, both crates need to be fixed in terms of supporting TCP keep-aliveretriesand retryintervals. The pull request to hyper has been accepted upstream to branch0.14.x, but the ETA of release is currently unknown.This pull request is to support full configuration of TCP keep-alive probes. In doing so, it
hyperto depend on the tip of branch0.14.x; andaxum-server v0.4.2and applys local patches to allow the configuration of all the TCP keep-alive parameters.Without this change, a busy server can easily run out of file descriptors if TCP keepalive is disabled, or end up having unstable persistent TCP connections (due to false positives of detecting dead connections) when TCP keepalive is enabled.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.