Adding rule based DL cases for typescript. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh-amazon
approved these changes
Dec 23, 2024
grl-wang
reviewed
Dec 24, 2024
Comment on lines
+12
to
+14
| // Compliant: Trusted user input is being passed into dynamically executable code. | ||
| let calculated: number = eval("2 + 3"); | ||
| res.send("Addition has been calculated"); |
There was a problem hiding this comment.
how it related to the user input?
grl-wang
reviewed
Dec 24, 2024
Comment on lines
28
to
30
| // Noncompliant: xfwd's defaults value is true. | ||
| xfwd: true | ||
| }); |
There was a problem hiding this comment.
there should be 1 default value of xfwd, is it true or false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add non compliant and compliant samples for typescript detectors.
Note: All the test cases have 100% recall and precision.