Added Compliant and NonCompliant DL cases for C language #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| int compliant() { | ||
| //Compliant : using `strsep_s()` can leads to crashes or security issues. | ||
| char *static_str = "message,token"; |
There was a problem hiding this comment.
Update the example here. Some mismatch.
| #include <stdlib.h> | ||
|
|
||
| void noncompliant() { | ||
| //NonCompliant : using `strtok()` tokenises strings safely via pointer without altering the original and also supports thread-safe parsing. |
There was a problem hiding this comment.
Some mismatch between compliant and non compliant
| int compliant(){ | ||
| //Compliant : Ensuring proper allocation and deallocation procedures. | ||
| int initial = 1000; | ||
| struct data *data = malloc(sizeof(*data)); |
There was a problem hiding this comment.
Can you cal the variable data_pointer
So,
struct data *data_ptr = malloc(sizeof(*data_ptr));
|
|
||
| int noncompliant() { | ||
| //NonCompliant : Avoid using `sscanf()` for number conversions. | ||
| const char *float_str = "3.1415926535897932384626433832"; |
There was a problem hiding this comment.
Can the length of the float be changed "3.14159" should be enough
| #include <stdio.h> | ||
|
|
||
| void compliant() { | ||
| //Compliant : Using `scanf()` explicitly null terminate buffer. |
There was a problem hiding this comment.
Comment is not clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added non compliant and compliant samples for C detectors.
Note: All the test cases have 100% recall and precision.