Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 10 more JavaScript Detector Library Samples #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 10 more JavaScript Detector Library Samples #101

wants to merge 1 commit into from

Conversation

saurabh-amazon
Copy link
Contributor

  • Added 10 more JavaScript detector library samples.

saurabh-amazon
saurabh-amazon commented Dec 27, 2024
View reviewed changes
...c/detectors/javascript-jwt-exposed-credential/javascript-jwt-exposed-credential_compliant.js
const jwt = require('jsonwebtoken');

const payload = {
// Compliant: Contains only non-sensitive data (no passwords or sensitive info).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for the following comment by @grl-wang

miss compliant comment and example look like Noncompliant
Ref: #91

Change made => Added the appropriate comment which explains that sensitive information like "password" is not a part of the payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saurabh-amazon