Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx addon fails on schema validation when certificate is specified. #677

Merged
merged 2 commits into from
May 9, 2023

Conversation

shapirov103
Copy link
Collaborator

Issue #, if available: #672

Description of changes:
Added proper types and validation including HTTPS to HTTP port redirection when terminating at the NLB level.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103
Copy link
Collaborator Author

/do-e2e-tests

Copy link

@aws-ia-ci aws-ia-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end to end tests passed

@shapirov103 shapirov103 merged commit bbf6e56 into main May 9, 2023
@shapirov103 shapirov103 deleted the bug/nginx branch May 10, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants