fix(internals): future distutils deprecation #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
heitorlessa
suggested changes
Dec 21, 2021
heitorlessa
approved these changes
Dec 21, 2021
|
Thanks a lot for the future-proof change @nayaverdier :) much appreciated! |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
jplock
reviewed
Dec 21, 2021
| from typing import Any, Optional, Union | ||
|
|
||
|
|
||
| def strtobool(value): |
There was a problem hiding this comment.
probably a good idea :)
|
Don’t worry, we’re gonna tackle this and 36 others during mypy fixes
…On Wed, 22 Dec 2021 at 07:22, Michael Brewer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In aws_lambda_powertools/shared/functions.py
<#921 (comment)>
:
> from typing import Any, Optional, Union
+def strtobool(value):
probably a good idea :)
—
Reply to this email directly, view it on GitHub
<#921 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBGA7QTYJQZK622G7J3USFVBFANCNFSM5KPL25IQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
.com>
|
|
haha. mypy does not complain about untyped methods :) |
|
IIRC there’s a strict mode that it can flag
…On Wed, 22 Dec 2021 at 07:25, Michael Brewer ***@***.***> wrote:
haha. mypy does not complain about untyped methods :)
—
Reply to this email directly, view it on GitHub
<#921 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBCQO4NKPA52RYCY52TUSFVOVANCNFSM5KPL25IQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
heitorlessa
added a commit
to ran-isenberg/aws-lambda-powertools-python
that referenced
this pull request
Dec 31, 2021
…tools-python into complex * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (24 commits) docs: consistency around admonitions and snippets (aws-powertools#919) chore(deps-dev): bump mypy from 0.920 to 0.930 (aws-powertools#925) fix(event-sources): handle dynamodb null type as none, not bool (aws-powertools#929) fix(apigateway): support @app.not_found() syntax & housekeeping (aws-powertools#926) docs: Added GraphQL Sample API to Examples section of README.md (aws-powertools#930) feat(idempotency): support dataclasses & pydantic models payloads (aws-powertools#908) feat(tracer): ignore tracing for certain hostname(s) or url(s) (aws-powertools#910) feat(event-sources): cache parsed json in data class (aws-powertools#909) fix(warning): future distutils deprecation (aws-powertools#921) docs(batch): remove leftover from legacy docs(layer): bump Lambda Layer to version 6 chore: bump to 1.23.0 docs(apigateway): add new not_found feature (aws-powertools#915) docs: external reference to cloudformation custom resource helper (aws-powertools#914) feat(logger): allow handler with custom kwargs signature (aws-powertools#913) chore: minor housekeeping before release (aws-powertools#912) chore(deps-dev): bump mypy from 0.910 to 0.920 (aws-powertools#903) feat(batch): new BatchProcessor for SQS, DynamoDB, Kinesis (aws-powertools#886) fix(parser): overload parse when using envelope (aws-powertools#885) fix(parser): kinesis sequence number is str, not int (aws-powertools#907) ...
heitorlessa
added a commit
to huonw/aws-lambda-powertools-python
that referenced
this pull request
Dec 31, 2021
…tools-python into feature/905-datetime * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(feature_flags): support beyond boolean values (JSON values) (aws-powertools#804) docs: consistency around admonitions and snippets (aws-powertools#919) chore(deps-dev): bump mypy from 0.920 to 0.930 (aws-powertools#925) fix(event-sources): handle dynamodb null type as none, not bool (aws-powertools#929) fix(apigateway): support @app.not_found() syntax & housekeeping (aws-powertools#926) docs: Added GraphQL Sample API to Examples section of README.md (aws-powertools#930) feat(idempotency): support dataclasses & pydantic models payloads (aws-powertools#908) feat(tracer): ignore tracing for certain hostname(s) or url(s) (aws-powertools#910) feat(event-sources): cache parsed json in data class (aws-powertools#909) fix(warning): future distutils deprecation (aws-powertools#921)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #906
Description of changes:
Removes dependency on distutils.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.