Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event-sources): handle Cognito claimsOverrideDetails set to null #878

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Dec 8, 2021

Issue #, if available:

Description of changes:

self._data["response"].setdefault("claimsOverrideDetails", {}) does not work, if claimsOverrideDetails was set to null in the json event (or None in the parsed Python)

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #878 (d7f357c) into develop (0348bd6) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #878      +/-   ##
===========================================
- Coverage    99.90%   99.88%   -0.02%     
===========================================
  Files          118      118              
  Lines         5126     5127       +1     
  Branches       571      572       +1     
===========================================
  Hits          5121     5121              
  Misses           2        2              
- Partials         3        4       +1     
Impacted Files Coverage Δ
.../utilities/data_classes/cognito_user_pool_event.py 99.73% <50.00%> (-0.27%) ⬇️
aws_lambda_powertools/metrics/metric.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0348bd6...d7f357c. Read the comment docs.

@heitorlessa heitorlessa added the bug Something isn't working label Dec 8, 2021
@heitorlessa heitorlessa merged commit de3cf28 into aws-powertools:develop Dec 8, 2021
@michaelbrewer michaelbrewer deleted the fix-870 branch December 8, 2021 18:49
@heitorlessa heitorlessa changed the title fix(event-sources): handle claimsOverrideDetails set to null fix(event-sources): handle Cognito claimsOverrideDetails set to null Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants