Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): fix data types for sourceIPAddress and sequencer fields in S3RecordModel Model #6154

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

DKurilo
Copy link
Contributor

@DKurilo DKurilo commented Feb 24, 2025

Issue number: #6150

Summary

make it possible for S3 object to have s3.amazonaws.com in sourceIPAddress and not to have sequencer

Changes

sourceIPAddress can be IP address or s3.amazonaws.com
sequencer is optional

User experience

Library failed during S3 LifecycleTransition parsin
Now it works.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@DKurilo DKurilo requested a review from a team as a code owner February 24, 2025 13:44
@boring-cyborg boring-cyborg bot added the tests label Feb 24, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2025
Copy link

boring-cyborg bot commented Feb 24, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@leandrodamascena leandrodamascena changed the title fix: LifecycleTransition S3 Event parser fix(parser): fix data types for sourceIPAddress and sequencer Fields in S3RecordSchema Model Feb 24, 2025
@leandrodamascena leandrodamascena changed the title fix(parser): fix data types for sourceIPAddress and sequencer Fields in S3RecordSchema Model fix(parser): fix data types for sourceIPAddress and sequencer fields in S3RecordSchema Model Feb 24, 2025
@leandrodamascena leandrodamascena changed the title fix(parser): fix data types for sourceIPAddress and sequencer fields in S3RecordSchema Model fix(parser): fix data types for sourceIPAddress and sequencer fields in S3RecordModel Model Feb 24, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (3544c54) to head (66cdf19).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6154   +/-   ##
========================================
  Coverage    96.19%   96.19%           
========================================
  Files          235      235           
  Lines        11229    11229           
  Branches       828      828           
========================================
  Hits         10802    10802           
  Misses         337      337           
  Partials        90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the super fast PR @DKurilo! APPROVED!

We will release a new version with this fix tomorrow.

@leandrodamascena leandrodamascena merged commit b72078f into aws-powertools:develop Feb 24, 2025
23 checks passed
Copy link

boring-cyborg bot commented Feb 24, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: There is no sequencer property in S3 LifecycleTransition event
2 participants