Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(feature-flags): correct link and json examples #605

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Aug 12, 2021

Issue #, if available:

Description of changes:

Minimal doc fixes for feature toggles link and json examples

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 12, 2021
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2021
@michaelbrewer
Copy link
Contributor Author

@heitorlessa minimal version of #603

@codecov-commenter
Copy link

Codecov Report

Merging #605 (25d9c62) into develop (f627b02) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #605      +/-   ##
===========================================
- Coverage    99.95%   99.91%   -0.05%     
===========================================
  Files          113      113              
  Lines         4535     4535              
  Branches       246      246              
===========================================
- Hits          4533     4531       -2     
- Misses           0        1       +1     
- Partials         2        3       +1     
Impacted Files Coverage Δ
aws_lambda_powertools/utilities/parser/types.py 71.42% <0.00%> (-28.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f627b02...25d9c62. Read the comment docs.

@heitorlessa heitorlessa merged commit 535b708 into aws-powertools:develop Aug 12, 2021
@michaelbrewer michaelbrewer deleted the docs/fix-minimal branch August 12, 2021 14:22
@heitorlessa heitorlessa changed the title fix(docs): correct feature_flags link and json examples docs(feature-flags): correct link and json examples Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants