docs(parser): improve documentation with Pydantic best practices #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
1 task
leandrodamascena
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Hey @AlphaWong! Thanks a lot for suggesting this change, I think this make lot of sense!
I just left a small comment to improve the message. Please let me know when you change this and then we can merge this PR.
Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Alpha <AlphaWong@users.noreply.github.com>
|
leandrodamascena
approved these changes
Jan 27, 2025
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #5926
Summary
root_validator(deprecated as of version 3.0.0) but the doc is outdated, theroot_validatordoc still appears on 3.2.0.Changes
If customers are migrating their library from version 2, refer to the latest documentation for updated methods compatible with
root_validatorUser experience
N/A
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
nopeRFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.