-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): remove 'aws:' prefix from SelfManagedKafka model #5584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5584 +/- ##
========================================
Coverage 96.16% 96.16%
========================================
Files 229 229
Lines 10836 10836
Branches 2015 2015
========================================
Hits 10420 10420
Misses 327 327
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for sending this PR @anafalcao! Great work!! 🚀
APPROVED!
|
Issue number:
#5559
Summary
Changes
The eventSource for self-managed Apache Kafka is not "eventSource": "aws:SelfManagedKafka" as we are currently using. It should be "eventSource": "SelfManagedKafka" as documented in the oficial Developer Guide https://docs.aws.amazon.com/lambda/latest/dg/with-kafka.html
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.