Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples): fix issues reported by SonarCloud and Scorecard #5315

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5314

Summary

Changes

SonarCloud and Scorecard ar reporting some issues with their dashboard and we will start fixing some of them

SonarCloud: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=aws-powertools_powertools-lambda-python
Scorecard: https://api.securityscorecards.dev/projects/github.com/aws-powertools/powertools-lambda-python

User experience

No changes for users

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team October 5, 2024 22:03
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 5, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2024
@github-actions github-actions bot added enhancement and removed documentation Improvements or additions to documentation labels Oct 5, 2024
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code labels Oct 5, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 5, 2024
@leandrodamascena leandrodamascena linked an issue Oct 5, 2024 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 7, 2024
Copy link

sonarqubecloud bot commented Oct 7, 2024

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 7, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the bar on these examples.

@leandrodamascena leandrodamascena merged commit 174f26f into develop Oct 7, 2024
7 checks passed
@leandrodamascena leandrodamascena deleted the fix/sonar-scorecard-errors branch October 7, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github-actions Pull requests that update Github_actions code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Fix some issues reported by Scorecard and Sonarcloud
2 participants