-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_source): add CodeDeploy Lifecycle Hook event #5219
feat(event_source): add CodeDeploy Lifecycle Hook event #5219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5219 +/- ##
========================================
Coverage 96.21% 96.21%
========================================
Files 228 229 +1
Lines 10746 10755 +9
Branches 2001 2003 +2
========================================
+ Hits 10339 10348 +9
Misses 321 321
Partials 86 86 ☔ View full report in Codecov by Sentry. |
Oh duh, I'll add tests. |
7a2e9c6
to
9e1c810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mw-root! Thanks a lot for working and fixing this PR! Everything looks great for me, we just need to this new class in our documentation. If you have problems to run the documentation locally, please let me know and I can help.
aws_lambda_powertools/utilities/data_classes/code_deploy_lifecycle_hook_event.py
Outdated
Show resolved
Hide resolved
tests/unit/data_classes/required_dependencies/test_code_deploy_lifecycle_hook_event.py
Outdated
Show resolved
Hide resolved
tests/unit/data_classes/required_dependencies/test_code_deploy_lifecycle_hook_event.py
Outdated
Show resolved
Hide resolved
…ycle_hook_event.py Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Mike W <12434761+mw-root@users.noreply.github.com>
Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Mike W <12434761+mw-root@users.noreply.github.com>
…_lifecycle_hook_event.py Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Mike W <12434761+mw-root@users.noreply.github.com>
…_lifecycle_hook_event.py Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Mike W <12434761+mw-root@users.noreply.github.com>
Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Mike W <12434761+mw-root@users.noreply.github.com>
|
@leandrodamascena thanks again for your help. Are docs auto-generated or should I add them by hand? I ran |
Our documentation is not automatically generated, but we are working on it somewhere in the near future. You need to open https://github.com/aws-powertools/powertools-lambda-python/blob/develop/docs/utilities/data_classes.md, and add an example in the
If you have already created the Poetry environment, you can use Please let me know if you have any additional question and I can help with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 small changes and we are good to merge! Go go go!! 🚀
Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Mike W <12434761+mw-root@users.noreply.github.com>
Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Mike W <12434761+mw-root@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED @mw-root! Thanks a lot for addressing all the feedback! 🥇
@leandrodamascena Thanks for all your help! |
We love it when we have people from the community helping us improve the project! It means the world to us. I'm justing waiting the CI turns green to merge the PR. |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #5171
Summary
This is a simple change to implement the lambda event type
CodeDeployLifeCycleHookLambdaEvent
.This event only provides
DeploymentId
andLifecycleEventHookExecutionId
(at least in my experience)Changes
This adds a new DictWrapper inherited class to define the properties passed by CodeDeployment.
User experience
This allows users to use the new class as an event type in their lambda handler
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
This is new functionality and is not a breaking change.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.