-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add the Metrics feature to nox tests #4552
chore(ci): add the Metrics feature to nox tests #4552
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4552 +/- ##
===========================================
+ Coverage 96.38% 96.43% +0.05%
===========================================
Files 214 219 +5
Lines 10030 10628 +598
Branches 1846 1976 +130
===========================================
+ Hits 9667 10249 +582
- Misses 259 267 +8
- Partials 104 112 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: should we only trust Nux test names to know what's required vs optional?
or (a) use a different test subfolder for each feature, (b) add a top-level docstring for those rearranged tests for optional dependency (like you did on noxfile:68
I think that's a good indication of what dependencies this subset of tests should use, no?
Can you elaborate further and give an example of what this would look like? |
Of course! We can reduce cognitive load on maintainers by making this even more explicit with a folder name that suggests the reason behind this separation. For example.
Alternatively, you could bundle As a byproduct, this also helps us detect regressions that were introduced in one dependency that now affects another unrelated class of tests. |
This is much better @heitorlessa! Thanks for always making things simple ❤️ |
f"{PREFIX_TESTS_FUNCTIONAL}/logger/required_dependencies/", | ||
f"{PREFIX_TESTS_FUNCTIONAL}/metrics/required_dependencies/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see how beautiful it is now - both in Nox and on folder structure <3 no ambiguity now!
Issue number: #4521
Summary
Changes
Adding the Metrics feature to nox tests
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.