Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update boto3 library version to 1.26.164+ #3632

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Jan 15, 2024

Issue number: #3631

Summary

Changes

We need to bump the boto3 library to 1.26.164+ to support the new ReturnValuesOnConditionCheckFailure feature for DynamoDB

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team January 15, 2024 14:32
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Jan 15, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@leandrodamascena leandrodamascena linked an issue Jan 15, 2024 that may be closed by this pull request
2 tasks
@rubenfonseca
Copy link
Contributor

Question: what happens if people depend on the boto3 that comes with the runtime? Currently: boto3-1.26.90

Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answering my own question: this is only for development and for layer customers

@leandrodamascena leandrodamascena merged commit 37a84c9 into aws-powertools:develop Jan 15, 2024
@allanlewis
Copy link

allanlewis commented Feb 7, 2024

@rubenfonseca @leandrodamascena This is a problem for my project. I want to exclude boto3 and botocore from my deployment package because they take up a lot of space, but if I depend on this package with the boto3 extra then I can't have the runtime version of boto3, 1.26.90 as you correctly state, as a dev dependency alongside.

If it's the case that this package absolutely won't work with older versions of boto3 then how does it work in the Lambda environment (for Python 3.9 and 3.10 at least) at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Bump boto3 library to 1.26.164+
3 participants