Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(idempotency): Correct examples and line highlights #312

Merged
merged 3 commits into from
Mar 6, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Mar 6, 2021

Description of changes:

Changes:

  • Removed accidentally checked in example file
  • Correct some examples in the codes
  • Correct the documented defaults for local_cache_max_items in IdempotencyConfig
  • Correct the highlighted lines in the examples
  • Correct formatting for Advanced title
  • Add link to idempontency docs from the Readme

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #312 (92af86d) into develop (696f93e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #312   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files           91       91           
  Lines         3338     3338           
  Branches       161      161           
========================================
  Hits          3334     3334           
  Misses           2        2           
  Partials         2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696f93e...92af86d. Read the comment docs.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Mar 6, 2021
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michael!!!

@heitorlessa heitorlessa merged commit 8b6a68b into aws-powertools:develop Mar 6, 2021
@michaelbrewer michaelbrewer deleted the chore-housekeeping-1.11 branch March 6, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants