-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(typing): move backwards compat types to shared types #3092
chore(typing): move backwards compat types to shared types #3092
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3092 +/- ##
===========================================
- Coverage 96.36% 96.36% -0.01%
===========================================
Files 185 185
Lines 8066 8064 -2
Branches 1510 1509 -1
===========================================
- Hits 7773 7771 -2
Misses 236 236
Partials 57 57
☔ View full report in Codecov by Sentry. |
Issue number: #3091
Summary
Moves all future types under
shared/types.py
to avoid common mistakes on version mismatch, plus additional import machinery.Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.