Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parameters): BaseProvider._get to also support Dict #3090

Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2250

Summary

Changes

This pull request extends the functionality of the _get method by adding support for an additional return type, Dict[str, Any]. Previously, the method returned either a str or bytes, limiting its usability with providers that return secrets as dictionary, like Vault by HashiCorp.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team September 14, 2023 11:48
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2023
@leandrodamascena leandrodamascena linked an issue Sep 14, 2023 that may be closed by this pull request
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@heitorlessa heitorlessa changed the title refactor(parameters): modify abstractmethod _get to support additional return types refactor(parameters): BaseProvider._get to also support Dict Sep 14, 2023
@leandrodamascena leandrodamascena merged commit 86619e5 into aws-powertools:develop Sep 14, 2023
@leandrodamascena leandrodamascena deleted the parameter/fixtyping branch September 14, 2023 14:57
@heitorlessa heitorlessa added the internal Maintenance changes label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: create your own parameters provider - Vault
2 participants