Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(automation): remove previous labels when PR is updated #3066

Merged
merged 2 commits into from
Sep 8, 2023
Merged

chore(automation): remove previous labels when PR is updated #3066

merged 2 commits into from
Sep 8, 2023

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Sep 8, 2023

Issue number: #1335

Summary

Changes

Please provide a summary of what's being changed

  • save_pr_details.js: saves labels as a part of the PR artifact object
  • label_pr_based_on_title.js: removes old labels as they're found based on the list within the same file
  • reusable_export_pr_details.yml: adds PR labels as an output.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team September 8, 2023 12:20
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Sep 8, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2023
@github-actions github-actions bot added the internal Maintenance changes label Sep 8, 2023
@heitorlessa
Copy link
Contributor

YEEEESSS!!!!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@heitorlessa
Copy link
Contributor

Merging as soon as release completes ;)

@heitorlessa heitorlessa merged commit 704f765 into develop Sep 8, 2023
@heitorlessa heitorlessa deleted the relabeling branch September 8, 2023 13:56
@leandrodamascena leandrodamascena linked an issue Sep 12, 2023 that may be closed by this pull request
Maintenance: Remove PR labels if title changes #1335
Closed
2 tasks
@heitorlessa heitorlessa mentioned this pull request Feb 21, 2024
Merged
7 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This is now released under 2.34.1 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

Assignees
No one assigned
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: Remove PR labels if title changes
2 participants
@sthulb @heitorlessa