Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export missing DynamoDBRecordEventName class #298

Closed
wants to merge 2 commits into from

Conversation

gianrubio
Copy link

@gianrubio gianrubio commented Feb 23, 2021

Description of changes:

The DynamoDBRecordEventName is not being exported, causing the following error

Traceback:
tests/test_lambda_handler.py:1: in <module>
    from src.lambda_handler import lambda_handler
src/lambda_handler.py:1: in <module>
    from aws_lambda_powertools.utilities.data_classes import (
E   ImportError: cannot import name 'DynamoDBRecordEventName' from 'aws_lambda_powertools.utilities.data_classes' (..../.venv/lib/python3.8/site-packages/aws_lambda_powertools/utilities/data_classes/__init__.py)

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@michaelbrewer
Copy link
Contributor

@gianrubio but you could also import it like via dynamo_db_stream_event

from aws_lambda_powertools.utilities.data_classes.dynamo_db_stream_event import DynamoDBRecordEventName

@gianrubio
Copy link
Author

yes, I know I can import it directly from the dynamo_db_stream_event. That's what I did as a workaround.
However the docs says otherwise. Would you prefer to fix the docs or to accept my pull request?

@michaelbrewer
Copy link
Contributor

yes, I know I can import it directly from the dynamo_db_stream_event. That's what I did as a workaround.
However the docs says otherwise. Would you prefer to fix the docs or to accept my pull request?

True, the docs are definitely wrong :)

@gianrubio gianrubio closed this Feb 26, 2021
@heitorlessa heitorlessa added area/utilities bug Something isn't working labels Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants