refactor(metrics): move from protocol to ABC; split provider tests

[leandrodamascena]

Issue number: #2916

Summary

Changes

This PR addresses the latest issues before we add the Datadog Metrics provider. There are no changes for the customer or even experience, this just fixes internal things.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[heitorlessa]

peer review comments

[codecov-commenter]

Codecov Report

Patch coverage: 90.66% and project coverage change: +0.10% 🎉

Comparison is base (b0a3658) 96.34% compared to head (fb2e260) 96.44%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2934      +/-   ##
===========================================
+ Coverage    96.34%   96.44%   +0.10%     
===========================================
  Files          169      171       +2     
  Lines         7678     7685       +7     
  Branches      1451     1452       +1     
===========================================
+ Hits          7397     7412      +15     
+ Misses         222      218       -4     
+ Partials        59       55       -4     

Files Changed	Coverage Δ
...s_lambda_powertools/metrics/provider/cold_start.py	100.00% <ø> (ø)
aws_lambda_powertools/metrics/functions.py	73.68% <73.68%> (ø)
aws_lambda_powertools/metrics/provider/base.py	95.23% <88.23%> (-2.06%)	⬇️
aws_lambda_powertools/metrics/base.py	71.23% <100.00%> (ø)
aws_lambda_powertools/metrics/metrics.py	96.36% <100.00%> (+4.69%)	⬆️
aws_lambda_powertools/metrics/provider/__init__.py	100.00% <100.00%> (ø)
...ools/metrics/provider/cloudwatch_emf/cloudwatch.py	94.44% <100.00%> (+2.59%)	⬆️
...owertools/metrics/provider/cloudwatch_emf/types.py	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[heitorlessa]

Almost there, I promise! log_metrics is incorrect, and I think there's some leftover from the Protocol implementation within tests.

[heitorlessa]

Quick patch to type CloudWatch EMF Output, it's an old old tech debt I always wanted to pay ever since we added typing extensions -- this will make asserting on tests easier too (and for customers!).

0001-refactor-type-EMF-output-with-TypedDict.patch

[leandrodamascena]

Quick patch to type CloudWatch EMF Output, it's an old old tech debt I always wanted to pay ever since we added typing extensions -- this will make asserting on tests easier too (and for customers!).

0001-refactor-type-EMF-output-with-TypedDict.patch

I applied this patch and addressed all feedback. Can you review it, please?

[heitorlessa]

checking 👀 !

[heitorlessa]

last changes as we luckily don't need those extra bits in testing ;)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

No Coverage information
No Duplication information