Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security): improve debugging for provenance script #2784

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jul 14, 2023

Issue number: #2203

Summary

@rubenfonseca and I were testing the new signed builds but didn't pass at first. Turns out cURL wasn't failing due to HTTP 404 calls - this PR fixes that and improve error messages.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team July 14, 2023 14:13
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 14, 2023
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team July 14, 2023 14:13
@github-actions github-actions bot added the internal Maintenance changes label Jul 14, 2023
@leandrodamascena leandrodamascena self-requested a review July 17, 2023 08:21
@leandrodamascena leandrodamascena merged commit ab0b065 into aws-powertools:develop Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants