Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: add support for custom lambda handlers with kwargs #242 #269

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jan 17, 2021

Issue #, if available: #242

Description of changes:

Tiny change to support customers using custom Lambda handler signatures (beyond event, context).

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* develop:
  chore: move env names to constant file (#264)
  docs: fix import (#267)
  feat: Add AppConfig parameter provider (#236)
  chore: update stale bot
  improv: override Tracer auto-capture response/exception via env vars (#259)
  docs: add info about extras layer (#260)
  feat: support extra parameter in Logger messages (#257)
  chore: general simplifications and cleanup (#255)
@heitorlessa heitorlessa changed the title improv: add support for custom lambda handlers with kwargs #262 improv: add support for custom lambda handlers with kwargs #242 Jan 17, 2021
@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #269 (61467a2) into develop (454d669) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #269   +/-   ##
========================================
  Coverage    99.75%   99.75%           
========================================
  Files           79       79           
  Lines         2820     2820           
  Branches       115      115           
========================================
  Hits          2813     2813           
  Misses           5        5           
  Partials         2        2           
Impacted Files Coverage Δ
aws_lambda_powertools/tracing/tracer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454d669...61467a2. Read the comment docs.

@heitorlessa
Copy link
Contributor Author

Merging as-is given the scope, and to allow @nmoutschen to review #268 as that's more important before we release tomorrow

@heitorlessa heitorlessa merged commit 1d0ee0e into aws-powertools:develop Jan 17, 2021
@heitorlessa heitorlessa deleted the improv/tracer-lambda-handler-kwargs branch January 17, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants