Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): fix idempotency tests #2576

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix(e2e): fix idempotency tests #2576

merged 2 commits into from
Jun 27, 2023

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #2552

Summary

Changes

Please provide a summary of what's being changed

This PR fixes two problems with our Idempotency E2E tests:

  • due to a breaking change in CDK, a Role was added to the stack that was not being deleted
  • due to a bug handling integer keys, our Idempotency code was not working correctly

User experience

Please share what the user experience looks like before and after this change

After this change we should see the E2E tests passing more often.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the tests label Jun 27, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2023
@github-actions github-actions bot added the bug Something isn't working label Jun 27, 2023
@rubenfonseca rubenfonseca linked an issue Jun 27, 2023 that may be closed by this pull request
2 tasks
@rubenfonseca rubenfonseca marked this pull request as ready for review June 27, 2023 07:56
@rubenfonseca rubenfonseca requested a review from a team June 27, 2023 07:56
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubenfonseca I made just a comment, but all good for me! ❤️

Co-authored-by: Leandro Damascena <lcdama@amazon.pt>
Signed-off-by: Ruben Fonseca <fonseka@gmail.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (acfd672) 97.21% compared to head (33e847a) 97.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2576   +/-   ##
========================================
  Coverage    97.21%   97.21%           
========================================
  Files          158      158           
  Lines         7368     7370    +2     
  Branches       536      537    +1     
========================================
+ Hits          7163     7165    +2     
  Misses         158      158           
  Partials        47       47           
Impacted Files Coverage Δ
...wertools/utilities/idempotency/persistence/base.py 97.19% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rubenfonseca rubenfonseca merged commit 78fb656 into develop Jun 27, 2023
@rubenfonseca rubenfonseca deleted the rf/fix-e2e-part-2 branch June 27, 2023 08:28
rafaelgsr pushed a commit to rafaelgsr/aws-lambda-powertools-python that referenced this pull request Jun 30, 2023
Co-authored-by: Leandro Damascena <lcdama@amazon.pt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech debt: Idempotency Thread safety E2E test is flaky
3 participants