-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): fix idempotency tests #2576
Conversation
1b0b21c
to
9ee268e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rubenfonseca I made just a comment, but all good for me! ❤️
aws_lambda_powertools/utilities/idempotency/persistence/base.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Leandro Damascena <lcdama@amazon.pt> Signed-off-by: Ruben Fonseca <fonseka@gmail.com>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2576 +/- ##
========================================
Coverage 97.21% 97.21%
========================================
Files 158 158
Lines 7368 7370 +2
Branches 536 537 +1
========================================
+ Hits 7163 7165 +2
Misses 158 158
Partials 47 47
☔ View full report in Codecov by Sentry. |
Co-authored-by: Leandro Damascena <lcdama@amazon.pt>
Issue number: #2552
Summary
Changes
This PR fixes two problems with our Idempotency E2E tests:
User experience
After this change we should see the E2E tests passing more often.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.