Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(navigation): make Key Feature the first section #2517

Merged
merged 1 commit into from
Jun 22, 2023
Merged

docs(navigation): make Key Feature the first section #2517

merged 1 commit into from
Jun 22, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2514

Summary

Changes

Make Key features default first as a navigation anchor in all documents and fix a capitalization issue.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team June 22, 2023 08:40
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jun 22, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2023
@leandrodamascena leandrodamascena changed the title docs: fix menu docs(general): make key feature as the default first item Jun 22, 2023
@leandrodamascena leandrodamascena changed the title docs(general): make key feature as the default first item docs(general): make Key feature as the default first item in all documents Jun 22, 2023
@leandrodamascena leandrodamascena changed the title docs(general): make Key feature as the default first item in all documents docs(navigation): make Key feature as the default first item in all documents Jun 22, 2023
@leandrodamascena leandrodamascena requested review from heitorlessa and removed request for a team June 22, 2023 08:44
@heitorlessa heitorlessa changed the title docs(navigation): make Key feature as the default first item in all documents docs(navigation): make Key Feature as the default first item in all documents Jun 22, 2023
@heitorlessa
Copy link
Contributor

looking 👀

@heitorlessa heitorlessa changed the title docs(navigation): make Key Feature as the default first item in all documents docs(navigation): make Key Feature the first section Jun 22, 2023
@heitorlessa
Copy link
Contributor

thanks a lot Le for the quick turnaround (and additional fixes!)

@heitorlessa heitorlessa merged commit 375640c into aws-powertools:develop Jun 22, 2023
@leandrodamascena leandrodamascena linked an issue Jun 22, 2023 that may be closed by this pull request
Docs: Idempotency key features navigation should come first #2514
Closed
1 task
rafaelgsr pushed a commit to rafaelgsr/aws-lambda-powertools-python that referenced this pull request Jun 30, 2023
@leandrodamascena @rafaelgsr
docs(navigation): make Key Feature the first section (aws-powertools#…
778e860 
…2517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Idempotency key features navigation should come first
2 participants
@leandrodamascena @heitorlessa