Updating dependencies regarding issues 721 715 714 691 #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapphil
reviewed
Sep 23, 2022
load-generator/build.gradle
Outdated
| implementation "io.opentelemetry:opentelemetry-sdk-metrics:1.4.1-alpha" | ||
| implementation "io.opentelemetry:opentelemetry-exporter-otlp:1.10.0" | ||
| implementation "io.opentelemetry:opentelemetry-exporter-otlp-metrics:1.4.1-alpha" | ||
| implementation "io.opentelemetry:opentelemetry-sdk-metrics:1.18.0" |
There was a problem hiding this comment.
Since you are use a bom, you don't need to define version for the dependencies:
https://blog.mrhaki.com/2019/04/gradle-goodness-use-bill-of-materials.html
You can just update the version of the bom:
implementation platform("io.opentelemetry:opentelemetry-bom:1.18.0")
implementation "io.opentelemetry:opentelemetry-api"
implementation "io.opentelemetry:opentelemetry-sdk-metrics"
....
There was a problem hiding this comment.
Thanks. updated accordingly.
| .setUnit("one") | ||
| .build(); | ||
|
|
||
| meter.gaugeBuilder(API_LATENCY_METRIC) |
There was a problem hiding this comment.
Maybe you can use a histogram to record latency instead of a gauge: https://aws-otel.github.io/docs/getting-started/java-sdk/trace-manual-instr#creating-metrics
There was a problem hiding this comment.
thanks. as discussed keeping Gauge for now.
| apiBytesSentCounter | ||
| .add(100, Labels.of(DIMENSION_API_NAME, API_NAME, DIMENSION_STATUS_CODE, "200")); | ||
| .add(10, METRIC_ATTRIBUTES); |
There was a problem hiding this comment.
Suggested change
| .add(10, METRIC_ATTRIBUTES); | |
| .add(10, METRIC_ATTRIBUTES); |
Why did you change the value being added? Will this affect the tests in any way?
bryan-aguilar
approved these changes
Sep 23, 2022
rapphil
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is to resolve issue #736.
Completed are #721, #715, #691, #714.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.