Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E2E Collector tests to use different collector names for each concurrent test #1654

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

thpierce
Copy link
Contributor

@thpierce thpierce commented Jul 10, 2024

Description:
We suspect that between this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2787/files - When two Collectors are created with the same name but different namespaces, the ClusterRoleBinding created by the first will be overriden by the second one and this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2938/files - Cleanup ClusterRoles and ClusterRoleBindings created by the operator ... The operator uses finalizer on the collector to run the cleanup, having multiple collectors with the same name is causing test failures like https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/9879456604/job/27295225403

In this commit, we are changing the E2E collector tests for fargate/non-fargate (which run concurrently) to use different collector names to ameliorate the test failures.

Note: AOC_NAMESPACE is not used anywhere else:

Link to tracking Issue: N/A

Testing: N/A

Documentation: N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thpierce thpierce requested a review from a team as a code owner July 10, 2024 23:16
@Aneurysm9 Aneurysm9 merged commit c0ad0f8 into aws-observability:terraform Jul 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants