Update E2E Collector tests to use different collector names for each concurrent test #1654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We suspect that between this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2787/files -
When two Collectors are created with the same name but different namespaces, the ClusterRoleBinding created by the first will be overriden by the second one
and this commit https://github.com/open-telemetry/opentelemetry-operator/pull/2938/files -Cleanup ClusterRoles and ClusterRoleBindings created by the operator ... The operator uses finalizer on the collector to run the cleanup
, having multiple collectors with the same name is causing test failures like https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/9879456604/job/27295225403In this commit, we are changing the E2E collector tests for fargate/non-fargate (which run concurrently) to use different collector names to ameliorate the test failures.
Note:
AOC_NAMESPACE
is not used anywhere else:Link to tracking Issue: N/A
Testing: N/A
Documentation: N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.