Use cluster name to choose AMI type for EKS MNG launch template #1050
+23
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
humivo
approved these changes
Jan 19, 2023
rapphil
reviewed
Jan 20, 2023
| @@ -57,7 +56,8 @@ export function deployClusters( | |||
| name: ec2Cluster.name, | |||
| vpc: vpc, | |||
| version: versionKubernetes, | |||
| instance_type: ec2Cluster.instance_type, | |||
| instanceTypes: [new InstanceType(ec2Cluster.instance_type.toLowerCase())], | |||
| amiType: ec2Cluster.name.match('\-arm64\-') ? NodegroupAmiType.AL2_ARM_64 : NodegroupAmiType.AL2_X86_64, | |||
There was a problem hiding this comment.
nit: We could pass the AMI type from the test_cluster.yaml file as well, so that we don't need to rely on the name.
There was a problem hiding this comment.
We could, but we already had the convention of including the architecture in the cluster name and matching on that is likely to be less error-prone than correctly copying the magic AMI type string. This also ensures that we only use one of these two AMI types.
rapphil
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony J Mirabella a9@aneurysm9.com
Description: Because we're specifying a launch template for the EKS managed nodegroups we're creating we need to tell it which AMI to use and that AMI needs to match the architecture for the instance type selected. Because all of our clusters include the architecture in the name I have chosen to extract that information from there rather than add a new field to the configuration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.