Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lambda remote service override configuration #325

Merged

Conversation

yiyuan-he
Copy link
Contributor

@yiyuan-he yiyuan-he commented Feb 10, 2025

Issue #, if available:
If user decides to override RemoteService value, the Lambda Topology issue solution will not be able to support multiple downstream Lambdas.

For example, consider lambdaA calls both lambdaB and lambdaC. If the user overrides LAMBDA_APPLICATION_SIGNALS_REMOTE_SERVICE, it will effectively hardcode the RemoteService value. As a result, we are left with an either/or situation where only one node will be connected to lambdaA in the topology depending on the hardcoded value. This issue is not present when the user does not override this RemoteService value because that attribute will dynamically take on whatever the lambda function name is.

My proposal is we remove the LAMBDA_APPLICATION_SIGNALS_REMOTE_SERVICE env var. That is, we do not allow customers to override the RemoteService attribute value. This should not cause issues for customers to lose this configuration option. If the customer needs to change the downstream lambda service name, they can change the lambda function name itself rather than having to use an env var.

Description of changes:
Removing option to override RemoteService attribute value.

Test plan:
Sanity e2e test by building custom lambda layer and ensuring the correct EMF Logs are still generated after change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yiyuan-he yiyuan-he requested a review from a team as a code owner February 10, 2025 20:57
@yiyuan-he yiyuan-he force-pushed the remove-remote-service-config branch 4 times, most recently from 882b207 to 60dd07c Compare February 10, 2025 21:54
@yiyuan-he yiyuan-he force-pushed the remove-remote-service-config branch from 60dd07c to 400c481 Compare February 10, 2025 23:43
@yiyuan-he yiyuan-he merged commit 9869674 into aws-observability:main Feb 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants