Update docs with instructions for windows build. #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #911 +/- ##
=======================================
Coverage 53.69% 53.69%
=======================================
Files 12 12
Lines 419 419
=======================================
Hits 225 225
Misses 177 177
Partials 17 17 Continue to review full report at Codecov.
|
7526e7c to
1680578
Compare
khanhntd
reviewed
Jan 29, 2022
| @@ -1,6 +1,6 @@ | |||
| ### Build Artifacts | |||
There was a problem hiding this comment.
Should we include requirements such as install make, git, golang version instead of having independent packages?
1680578 to
ae364d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added make target for windows build. Chocolatey is already required for
create_msi.ps1, so it can likely be used to installmakeas well. https://community.chocolatey.org/packages/makeaws-otel-collector/tools/packaging/windows/create_msi.ps1
Line 16 in 7a824b5
Link to tracking Issue: #893