add for all dev branch #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethAmazon
approved these changes
Jan 6, 2022
jefchien
approved these changes
Jan 6, 2022
jefchien
reviewed
Jan 6, 2022
| @@ -17,7 +17,7 @@ on: | |||
| branches: | |||
| - main | |||
| - release/v* | |||
| - dev | |||
| - dev/* | |||
There was a problem hiding this comment.
We still have a dev branch even if it isn't really in use. Should we still have the CI run on it? This change will remove that.
There was a problem hiding this comment.
There are two ways for us to change it: one is to rename the branch as dev/ and second is that change the prefix pattern to dev*. I prefer the former one since it will avoid some of the naming convention that may be confused with dev*.
There was a problem hiding this comment.
The other way is to just have two entries
- dev
- dev/*
There was a problem hiding this comment.
Reasonable. Fixed it.
jefchien
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For all of the branch that has the prefix "dev", it would trigger the CI. In this way, we can test the CI.
Testing:
An alternative solution would be using act https://github.com/nektos/act