Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-otel-emitter container image #822

Closed
wants to merge 1 commit into from

Conversation

b-0-b
Copy link

@b-0-b b-0-b commented Dec 21, 2021

aottestbed/aws-otel-collector-sample-app:java-0.1.0 defaults to using localhost/127.0.0.1:55680 and setting OTEL_OTLP_ENDPOINT does not change anything.

Caused by: io.grpc.netty.shaded.io.netty.channel.AbstractChannel$AnnotatedConnectException: finishConnect(..) failed: Connection refused: localhost/127.0.0.1:55680

Description:

We are evaluating AWS Distro for OpenTelemetry and had some issues getting the demo app working correctly. Changing the container image solved our problem.

Link to tracking Issue:

Testing:

Just apply the example Kubernetes config. At least for everyone on our team that tried this, the emitter tried to connect to the collector on port 55680 and we could not change that with OTEL_OTLP_ENDPOINT

Documentation:

aottestbed/aws-otel-collector-sample-app:java-0.1.0 defaults to using `localhost/127.0.0.1:55680` and setting `OTEL_OTLP_ENDPOINT` does not change anything.

```shell
Caused by: io.grpc.netty.shaded.io.netty.channel.AbstractChannel$AnnotatedConnectException: finishConnect(..) failed: Connection refused: localhost/127.0.0.1:55680
```
@b-0-b b-0-b requested a review from a team as a code owner December 21, 2021 08:39
@jefchien
Copy link
Member

Hi @b-0-b,

Thanks for the contribution! That's a great catch! We must have missed that the last time we updated the sample app references (#604). As can be seen in that PR, we updated the sample app and added it to one of our public ECRs: public.ecr.aws/aws-otel-test/aws-otel-java-test-spark:v0.11.0. This isn't the only example that still uses aottestbed/aws-otel-collector-sample-app:java-0.1.0. We'll need to evaluate the current sample app and determine what image the examples should all point to.

@@ -26,7 +26,7 @@ spec:
spec:
containers:
- name: aws-otel-emitter
image: "aottestbed/aws-otel-collector-sample-app:java-0.1.0"
image: "aottestbed/aws-otel-collector-java-sample-app:0.9.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: "aottestbed/aws-otel-collector-java-sample-app:0.9.0"
image: "public.ecr.aws/aws-otel-test/aws-otel-java-test-spark:v0.11.0"

Please use the most recent image version of the spark sample app.

@jefchien
Copy link
Member

Thanks for letting us know about the issue. We've updated our examples to the latest spark app. (#900)

@jefchien jefchien closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants