Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change release note header wording. #754

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

jefchien
Copy link
Member

Description: Updated to match revised wording from patch release.

@@ -23,7 +23,7 @@ VERSION=`cat VERSION`
OUTPUT="docs/releases/${RELEASE_VERSION}.md"

# generate release note
docker run -it -v "`pwd`":/usr/local/src/your-app ferrarimarco/github-changelog-generator \
docker run -it -v --rm "`pwd`":/usr/local/src/your-app ferrarimarco/github-changelog-generator \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't removing the container after being run, which was leaving me with a bunch of containers I would have to manually clean up.

@jefchien jefchien requested a review from sethAmazon November 18, 2021 18:01
@khanhntd khanhntd merged commit 831bd4a into aws-observability:main Nov 19, 2021
@jefchien jefchien deleted the fix-release-note-header branch November 22, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants