Update ECS App Metrics default config for CloudWatch #749
Conversation
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 54.69% 54.69%
=======================================
Files 11 11
Lines 298 298
=======================================
Hits 163 163
Misses 118 118
Partials 17 17 Continue to review full report at Codecov.
|
|
Prom test case is failing, not sure if it is related. |
|
|
||
| exporters: | ||
| awsemf/application: | ||
| namespace: ECS/AWSOTel/Application | ||
| log_group_name: '/aws/ecs/application/metrics' | ||
| resource_to_telemetry_conversion: | ||
| enabled: true | ||
| dimension_rollup_option: NoDimensionRollup | ||
| metric_declarations: | ||
| - dimensions: [ [ TaskDefinitionFamily ] ] |
There was a problem hiding this comment.
I believe without this allow list, this will cause every resource dimension to be sent, which could be dozens, and likely fail to ingest to CW or otherwise cost too much. Don't we need to add a reasonable allow list here? I heard that TaskDefinitionFamily may not be sufficient, in that case what do we need and can we add them all here in the allow list instead of removing it?
There was a problem hiding this comment.
Yes @anuraaga. I am working on a new config. Discussing offline. Planning to allow a specific set of dimensions which are truly useful for ECS customers.
This was an issue I saw when refactoring the mock servers even before that. Investigating the issue: aws-observability/aws-otel-test-framework#404 |
|
Do not merge this. I am testing a new set of dimnsions. |
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
|
Do I understand config correctly, this will export the following dimensions: |
|
Hi @genbit, We didn’t choose any dimension rollup option in the config. So it will use the default setup for |
Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
* Update ecs default config for CloudWatch Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com> * Select proper dimensions for ECS customers Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com> * add NoDimensionRollUp for awsemf exporter Signed-off-by: Rayhan Hossain <hossain.rayhan@outlook.com>
Signed-off-by: Rayhan Hossain hossain.rayhan@outlook.com
Description:
This PR will update our default ECS app metrics config for CloudWatch. We will offer a minimal set of metric dimensions/labels which are truly useful for our customers. For customers who want more dimensions (less common use case) can always come up with their custom config.
Proposed dimensions/labels: