Separate ecs cloudwatch container insights into separate configs #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossain-rayhan
approved these changes
Nov 8, 2021
Signed-off-by: Sergey Generalov <serggen@amazon.com>
alolita
approved these changes
Nov 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage 54.69% 54.69%
=======================================
Files 11 11
Lines 298 298
=======================================
Hits 163 163
Misses 118 118
Partials 17 17 Continue to review full report at Codecov.
|
jefchien
approved these changes
Nov 9, 2021
jefchien
pushed a commit
that referenced
this pull request
Nov 17, 2021
Signed-off-by: Sergey Generalov <serggen@amazon.com> Co-authored-by: Sergey Generalov <serggen@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: v0.14.0 introduced two new configs for Amazon ECS that enables both application Otel metrics export to CloudWatch Metrics and ECS container insights metrics to CloudWatch Container Insights metrics. This PR splits those configs into two parts, to allow customers enable both Container Insights at ECS cluster level and OpenTelemetry.