Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log on failure to get latest uploaded release candidate #678

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

sethAmazon
Copy link
Member

@sethAmazon sethAmazon commented Oct 21, 2021

Description:
Bug: Would try to download latest commit of agent. The latest commit of the agent could have failed the ci thus not uploaded. Now echo a message saying to look for that commit hash in ci when failed.

Testing:
Add push and secrets to my fork ran on my github actions

@codecov-commenter
Copy link

Codecov Report

Merging #678 (4c54cc2) into main (f629356) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   64.38%   64.38%           
=======================================
  Files           8        8           
  Lines         219      219           
=======================================
  Hits          141      141           
  Misses         62       62           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f629356...4c54cc2. Read the comment docs.

@sethAmazon sethAmazon force-pushed the fix-soaking-test branch 3 times, most recently from 3a3f36c to 1ec8c80 Compare October 21, 2021 20:09
@anuraaga anuraaga changed the title Get Latest Uploaded Release Candidate Log on failure to get latest uploaded release candidate Oct 22, 2021
@@ -11,13 +11,13 @@
# express or implied. See the License for the specific language governing
# permissions and limitations under the License.

name: 'nightly soaking test'
name: 'weekly soaking test'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jefchien jefchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All very minor nitpicks. LGTM.

.github/workflows/soaking.yml Outdated Show resolved Hide resolved
.github/workflows/soaking.yml Outdated Show resolved Hide resolved
.github/workflows/soaking.yml Outdated Show resolved Hide resolved
@jefchien jefchien merged commit 6d86545 into aws-observability:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants