-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror Operator images from Quay and GCR to AWS Observability ECR public gallery #592
Mirror Operator images from Quay and GCR to AWS Observability ECR public gallery #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks the same with open-o11y#9
Hi @Saber-W, we need to setup the ADOT Operator testing in ADOT test framework. Could you help on it? I can discuss with you if you can help. |
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 63.38% 63.38%
=======================================
Files 8 8
Lines 213 213
=======================================
Hits 135 135
Misses 62 62
Partials 16 16 Continue to review full report at Codecov.
|
Hi @mxiamxia, yes, this one is the same with that PR which you have reviewed.
Yes. Could you please elaborate on what testing exactly? Since this PR just mirrors the images, do you mean to write unit tests about the mirroring functions? |
d
Since we're going to support ADOT Operator. I want to add ADOT Operator testing in ADOT integ test framework (for EKS) to cover at least AMP, X-Ray and CW Metric test case. So everytime when a new PR sent orADOT release. The operator test case will download the Operator and apply CRD with the new ADOT Collector image with the changes and run the current test cases on those 3 types of data. |
I understand, and we could do this end-to-end testing. I suggest setting up a meeting to further discuss this. cc @alolita |
Description:
This PR uses and modifies a third-party repository (docker-mirror) to mirror two repositories (operator repo & kube-rbac-proxy repo) to aws-observability ECR public gallery. The names of the two corresponding repositories are adot-operator and mirror-kube-rbac-proxy respectively.
Every time the new version of the ADOT collector is released, we will also push the newest Operator images to AWS Observability ECR public gallery.
cc @alolita @mxiamxia