Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OTel Collector deps to v0.22 #392

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Conversation

mxiamxia
Copy link
Member

Description:

  • Upgrade OTel Collector lib to the latest version (v 0.22)
  • Fixed the breaking public API changes

Link to tracking Issue:

Testing:
make build

@mxiamxia mxiamxia requested a review from vastin March 10, 2021 22:16
@mxiamxia
Copy link
Member Author

NewRelic Exporter failed on integration test after bumping up the version to v0.22. @alanwest

@alanwest
Copy link

NewRelic Exporter failed on integration test after bumping up the version to v0.22. @alanwest

Thanks, @mxiamxia, I've pushed an update here aws-observability/aws-otel-test-framework#240.

I believe this should be the fix, though I'm having trouble running the test suite locally. I can look at this closer tomorrow.

Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test failed
--- FAIL: TestGetCfgFactoryWithoutConfig (0.00s)

@a-feld
Copy link
Contributor

a-feld commented Mar 11, 2021

@vastin I opened a separate PR here

@vastin
Copy link
Contributor

vastin commented Mar 11, 2021

@a-feld The unit test failure of TestGetCfgFactoryWithoutConfig is another issue which might be changes in pkg/config/config_factory_test.go

@mxiamxia mxiamxia force-pushed the v_0_22 branch 2 times, most recently from cdc0331 to 75f4df3 Compare March 11, 2021 19:33
@mxiamxia mxiamxia requested a review from vastin March 11, 2021 19:36
@mxiamxia
Copy link
Member Author

@alanwest @a-feld , it looks NewRelic exporter is still failing from mock test. I am not sure how aws-observability/aws-otel-test-framework#241 could be related. Could you please elaborate it a bit?

@a-feld
Copy link
Contributor

a-feld commented Mar 12, 2021

A breaking change was introduced to the New Relic exporter in the latest release. HTTP path for the New Relic exporter cannot be overridden. All HTTP posts must be sent to a URL in the form of:

https://{host:port}/trace/v1
https://{host:port}/metric/v1

Since path is not configurable, the exporter cannot be configured to send data to the URL:

https://mocked-server/put-data

To fix the tests, the mock server has been updated to accept any path on the https port as data in aws-observability/aws-otel-test-framework#241

The NR exporter is then configured to send data to:

https://mocked-server/trace/v1
https://mocked-server/metric/v1

@vastin vastin merged commit f1068e5 into aws-observability:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants