-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update OTel Collector deps to v0.22 #392
Conversation
NewRelic Exporter failed on integration test after bumping up the version to v0.22. @alanwest |
Thanks, @mxiamxia, I've pushed an update here aws-observability/aws-otel-test-framework#240. I believe this should be the fix, though I'm having trouble running the test suite locally. I can look at this closer tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test failed
--- FAIL: TestGetCfgFactoryWithoutConfig (0.00s)
@a-feld The unit test failure of TestGetCfgFactoryWithoutConfig is another issue which might be changes in pkg/config/config_factory_test.go |
cdc0331
to
75f4df3
Compare
@alanwest @a-feld , it looks NewRelic exporter is still failing from mock test. I am not sure how aws-observability/aws-otel-test-framework#241 could be related. Could you please elaborate it a bit? |
A breaking change was introduced to the New Relic exporter in the latest release. HTTP path for the New Relic exporter cannot be overridden. All HTTP posts must be sent to a URL in the form of:
Since path is not configurable, the exporter cannot be configured to send data to the URL:
To fix the tests, the mock server has been updated to accept any path on the https port as data in aws-observability/aws-otel-test-framework#241 The NR exporter is then configured to send data to:
|
Description:
Link to tracking Issue:
Testing:
make build