Fix: fix upstart style init script #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix the upstart init script so that it can be used in systems that don't have systemd.
Notably, it seems that some Cloud9 workspaces are based on Amazon Linux 1, which does not have support to systemd.
reference: https://linux.die.net/man/5/init
This regression was not caught in our integration tests because we do not test any distro that do not use systemd as default service management mechanism. We used to test Amazon Linux 1, but that is not the case anymore.
Testing: tested locally in Cloud9 IDE which uses AL1
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.