Disable pkg.translator.prometheus.NormalizeName feature gate by default #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapphil
reviewed
May 5, 2023
| @@ -92,6 +92,15 @@ func main() { | |||
| // our default component list. Flags also need to be parsed before creating the config provider. | |||
| func buildAndParseFlagSet(featgate *featuregate.Registry) (*flag.FlagSet, error) { | |||
| flagSet := config.Flags(featgate) | |||
|
|
|||
| // TODO: remove after ADOT Collector v0.30.0 is released | |||
| if err := featgate.Set("pkg.translator.prometheus.NormalizeName", false); err != nil { | |||
There was a problem hiding this comment.
how users can opt-in into using the normalized names?
There was a problem hiding this comment.
The instructions are in the linked issue. Do you think we need to duplicate it here?
There was a problem hiding this comment.
I'm asking if it is possible to override this from the command line, since this is hard coded. is it?
There was a problem hiding this comment.
Yes it is possible. The feature gate flags are parsed later on in collector initialization. If a user provides --featuregates=+pkg.translator.prometheus.NormalizeName at startup it will be overridden.
humivo
reviewed
May 8, 2023
humivo
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Disables the
pkg.translator.prometheus.NormalizeNamefeature gate by default.Issue #2043
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.