Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Lambdacomponents to aws-otel-lambda #1884

Closed
wants to merge 4 commits into from
Closed

Move Lambdacomponents to aws-otel-lambda #1884

wants to merge 4 commits into from

Conversation

Kausik-A
Copy link
Contributor

Description:

This PR is in pair with aws-observability/aws-otel-lambda#481 which moves over the lambdacomponents module from aws-otel-collector to aws-otel-lambda

Testing:

Built the collector layer locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Kausik-A Kausik-A marked this pull request as ready for review February 27, 2023 19:57
@Kausik-A Kausik-A requested a review from a team as a code owner February 27, 2023 19:57
Copy link
Contributor

@erichsueh3 erichsueh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's make sure that any changes to the lambda release process is captured as well

@Kausik-A
Copy link
Contributor Author

lambdacomponents were introduced inside aws-otel-lambda as part of this PR and show successful run of the integration tests. Merging this PR now

@rapphil
Copy link
Member

rapphil commented Mar 10, 2023

@Aneurysm9 was suggesting to add a deprecation warning first before removing altogether.

@rapphil
Copy link
Member

rapphil commented Mar 10, 2023

Here are instructions for deprecating https://go.dev/ref/mod#go-mod-file-module-deprecation

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 9, 2023
@bryan-aguilar
Copy link
Contributor

Closed in favor of #1981

@bryan-aguilar bryan-aguilar deleted the RemoveLambda branch April 17, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants