Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade OTel dependencies to v0.68.0 collector/collector-contrib #1736

Merged
merged 8 commits into from
Jan 4, 2023
Merged

Upgrade OTel dependencies to v0.68.0 collector/collector-contrib #1736

merged 8 commits into from
Jan 4, 2023

Conversation

PaurushGarg
Copy link
Member

@PaurushGarg PaurushGarg commented Jan 4, 2023 •
edited
Loading

Description:

  • Made changes that are required to bump dependencies of upstream collector/contrib version to v0.68.0- as this version has deprecation and breaking changes.
  • Ran make fmt.
  • Upgraded other dependencies to recent versions.
  • Presently, indirect dependency of github.com/DataDog/agent-payload/v5 v5.0.59 had to be replaced with v5.0.49 due to unknown revision v5.0.59 error.

Testing: Ran unit tests and built without issue on local.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@PaurushGarg PaurushGarg requested a review from a team as a code owner January 4, 2023 01:27
@PaurushGarg PaurushGarg self-assigned this Jan 4, 2023
Aneurysm9
Aneurysm9 reviewed Jan 4, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@PaurushGarg PaurushGarg marked this pull request as draft January 4, 2023 02:03
@bryan-aguilar
Copy link
Contributor

running make test and make build will also help ensure that you didn't miss any linting/deprecations before submitting the PR.

bryan-aguilar
bryan-aguilar reviewed Jan 4, 2023
View reviewed changes
cmd/awscollector/main.go Outdated Show resolved Hide resolved
cmd/awscollector/main_others.go Outdated Show resolved Hide resolved
@bryan-aguilar
Copy link
Contributor

Also, please update the PR title. This PR does not bump ADOT Collector versions but updates upstream OTel dependency versions.

@bryan-aguilar
Copy link
Contributor

Can you also be sure to update the non OTel dependency versions. Dependabot is struggling because it keeps trying to downgrade the signalfx dependency version. So PR updates to the aws-sdk dependency are failing.

@PaurushGarg PaurushGarg changed the title Draft: Release fix v0.25.0 Upgrade dep to v0.68.0 collector/collector-contrib Jan 4, 2023
@PaurushGarg PaurushGarg changed the title Upgrade dep to v0.68.0 collector/collector-contrib Upgrade OTel dep to v0.68.0 collector/collector-contrib Jan 4, 2023
@PaurushGarg PaurushGarg changed the title Upgrade OTel dep to v0.68.0 collector/collector-contrib Upgrade OTel dependencies to v0.68.0 collector/collector-contrib Jan 4, 2023
@PaurushGarg PaurushGarg marked this pull request as ready for review January 4, 2023 07:12
@PaurushGarg PaurushGarg merged commit df624a4 into aws-observability:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasireddy99 vasireddy99 vasireddy99 approved these changes

@bryan-aguilar bryan-aguilar bryan-aguilar approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@PaurushGarg PaurushGarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PaurushGarg @bryan-aguilar @Aneurysm9 @vasireddy99