Ensure feature gate flag values are applied to global registry #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
vasireddy99
approved these changes
Mar 14, 2022
bryan-aguilar
added a commit
that referenced
this pull request
May 26, 2022
* Ensure feature gate flag values are applied to global registry (#1053) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Remove conditional check from logging wrapper (#1213) * Remove conditional check from logging wrapper * Update cmd/awscollector/main.go Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * Add logging option to struct literal Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * rerunning the test cases * changed the version back to v0.17.0 Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony J Mirabella a9@aneurysm9.com
Description: Ensure that feature gate flags are applied before the collector starts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.