Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Takes too long to build otel container in test cases #716

Closed
sethAmazon opened this issue Nov 5, 2021 · 0 comments
Closed

Takes too long to build otel container in test cases #716

sethAmazon opened this issue Nov 5, 2021 · 0 comments

Comments

@sethAmazon
Copy link
Member

Is your feature request related to a problem? Please describe.
Takes too long to build otel container in test cases. This is because we do not cache the go mods when we build in the ec2 instance.

Describe the solution you'd like
Build once and upload to ecr then take the docker image from there

Describe alternatives you've considered
Move go mod cache into the dockerfile
Move the building of otel outside of the docker file.

Additional context
https://github.com/aws-observability/aws-otel-collector/runs/4119657628?check_suite_focus=true
@khanhntd khanhntd mentioned this issue Nov 8, 2021
Closed
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Nov 8, 2021
@sethAmazon @khanhntd
Move Out Binary Build From Dockerfile (aws-observability#716)
d6fc146 
Co-authored-by: Khanh Nguyen <khanhntd@amazon.com>
@sethAmazon sethAmazon mentioned this issue Nov 8, 2021
Merged
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Nov 8, 2021
@sethAmazon @khanhntd
Move Out Binary Build From Dockerfile (aws-observability#716)
2acf274 
Co-authored-by: Khanh Nguyen <khanhntd@amazon.com>
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Nov 9, 2021
@sethAmazon @khanhntd
Move Out Binary Build From Dockerfile (aws-observability#716)
09c78d0 
Co-authored-by: Khanh Nguyen <khanhntd@amazon.com>
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Nov 9, 2021
@sethAmazon @khanhntd
Move Out Binary Build From Dockerfile (aws-observability#716)
044e24f 
Co-authored-by: Khanh Nguyen <khanhntd@amazon.com>
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Nov 9, 2021
@sethAmazon @khanhntd
Move Out Binary Build From Dockerfile (aws-observability#716)
b50f4f3 
Co-authored-by: Khanh Nguyen <khanhntd@amazon.com>
jefchien pushed a commit that referenced this issue Nov 9, 2021
@sethAmazon @khanhntd
Move Out Binary Build From Dockerfile (#716) (#721)
6df45e1 
Co-authored-by: Khanh Nguyen <khanhntd@amazon.com>
@khanhntd khanhntd closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sethAmazon @khanhntd