Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Builds #679

Closed
sethAmazon opened this issue Oct 21, 2021 · 0 comments
Closed

Nightly Builds #679

sethAmazon opened this issue Oct 21, 2021 · 0 comments

Comments

@sethAmazon
Copy link
Member

sethAmazon commented Oct 21, 2021

**Is your feature request related to a problem?
No nightly builds

Describe the solution you'd like
Add a nightly build

Describe alternatives you've considered
Not adding a nightly build and forcing users to build them selfs

Additional context
Nightly Build Unit Tests For ADOT

Why?

  • We want to prove on nightly basis unit tests are passing
  • Standard to run nightly builds https://en.wikipedia.org/wiki/Daily_build
    • The industry is moving in a direction of ci / unit test against every merge of code
      • We must make the nightly build easily changeable to a ci build
  • Have a nightly docker container release

What?

  • Unit test adot

    • make test
  • Unit test common aws components from the contrib

  • Add nightly docker container to ecr

How?

  • Github actions

  • Schedule cron for midnight

    • Github uses a non standard cron expression
        • cron: *'0 0 * * ' # run at mid night
  • Add a new public ecr repo that contains adot nightly builds

  • Iterative steps for adding tests

Steps

  1. Unit test adot
  2. Add testing of common aws contrib components
    2.5. Maintain adding common aws contrib components as more are added
  3. Add a step to upload a docker container to ecr
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 21, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 22, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 22, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 22, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 22, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 25, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 25, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 25, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 25, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 25, 2021
sethAmazon added a commit to sethAmazon/aws-otel-collector that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant