Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update provider details in examples and module #22

Merged

Conversation

quixoticmonk
Copy link
Collaborator

Description

The PR updates the tfe provider details in the examples required for the agent pool to be created. This additionally removes the awscc provider details which is not used in the configuration.

Type of Change

  • Non breaking changes

Copy link

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.
If we proceed with reviewing this pr and it is merged this will result in the publication of your project. If you are
not ready to publish yet, we recommend you close this PR and develop against a different branch.
Once you are ready to publish you can open a PR from that branch to main.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS PoC who is assisting you with this project.

@gautambaghel
Copy link
Collaborator

@wellsiau-aws -- @quixoticmonk has been speaking behind the scenes about working/helping out on this!

Can I be made a reviewer on this repo? how does aws-ia work?

@quixoticmonk quixoticmonk force-pushed the fix/examples-provider-version branch from 4a54089 to f11c939 Compare May 23, 2024 21:16
@quixoticmonk quixoticmonk marked this pull request as ready for review May 26, 2024 21:27
Copy link
Collaborator

@wellsiau-aws wellsiau-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wellsiau-aws wellsiau-aws requested a review from gautambaghel May 30, 2024 21:05
Copy link
Collaborator

@gautambaghel gautambaghel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tbulding tbulding self-requested a review June 3, 2024 17:46
@wellsiau-aws wellsiau-aws merged commit 7a86698 into aws-ia:main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants