Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unused imports, unused context, typos #4

Merged
merged 6 commits into from
Sep 5, 2024
Merged

fix: unused imports, unused context, typos #4

merged 6 commits into from
Sep 5, 2024

Conversation

quixoticmonk
Copy link
Collaborator

@quixoticmonk quixoticmonk commented Aug 31, 2024 •
edited
Loading

Description

  • Removed unused imports in some lambda code
  • fixed some typos in the CONTRIBUTING docs
  • logging referenced workspace_name which doesn't exit in runtask_fulfillment.
  • fixed arg name when passing config_file for process_run_task in runtask_fulfillment

Couple of deployment runs:

  • EKS with NewRelic dashboard
    Screenshot 2024-08-31 at 23 15 46
  • S3 bucket
    Screenshot 2024-08-31 at 23 16 14
  • S3 bucket with tag named password
Screenshot 2024-09-01 at 22 15 48

@quixoticmonk quixoticmonk marked this pull request as ready for review September 1, 2024 03:17
gautambaghel
gautambaghel approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@gautambaghel gautambaghel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! didn't realize we had so many typos, thanks for the PR

@wellsiau-aws
Copy link
Collaborator

/do-e2e-tests

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

End to end test has been scheduled

@aws-ia-automator-prod aws-ia-automator-prod
Copy link

E2E tests in progress

aws-ia-automator-prod[bot]
aws-ia-automator-prod bot approved these changes Sep 5, 2024
View reviewed changes
Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

wellsiau-aws
wellsiau-aws approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@wellsiau-aws wellsiau-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not bumping version yet

@wellsiau-aws wellsiau-aws merged commit 8eeb9df into main Sep 5, 2024
3 checks passed
@wellsiau-aws wellsiau-aws deleted the fix/imports-docs-errors branch September 7, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautambaghel gautambaghel gautambaghel approved these changes

@wellsiau-aws wellsiau-aws wellsiau-aws approved these changes

@aws-ia-automator-prod aws-ia-automator-prod[bot] aws-ia-automator-prod[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quixoticmonk @wellsiau-aws @gautambaghel