Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.0.1 #3

Merged
merged 28 commits into from
Aug 27, 2024
Merged

V0.0.1 #3

merged 28 commits into from
Aug 27, 2024

Conversation

wellsiau-aws
Copy link
Collaborator

@wellsiau-aws wellsiau-aws commented Aug 27, 2024

Candidate release v0.0.1

  • Bedrock guardrail included

Copy link

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS contact assisting you with this project.

@wellsiau-aws wellsiau-aws self-assigned this Aug 27, 2024
@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run task Terrraform plan analyzer

@@ -10,12 +10,19 @@ Integrate Amazon Bedrock to your HashiCorp Cloud Platform Terraform (Terraform C

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to include the term Agentic here because we're using that on our landing pages

@@ -29,6 +36,7 @@ Please refer to the [best-practice](#best-practice) section below for more detai
To use this module you need have the following:

1. AWS account and credentials
1. Amazon Bedrock model access (default model is `Claude 3 Sonnet`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention, lamdba, cloudfront and WAF access as well?

Copy link
Collaborator

@gautambaghel gautambaghel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, couple of minor nit picks

@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

@wellsiau-aws
Copy link
Collaborator Author

/confirm-publication

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review has been requested from required contributors, once they have approved I will remove my request for changes. When this PR is merged your project will be published

@wellsiau-aws wellsiau-aws added the enhancement New feature or request label Aug 27, 2024
Copy link
Collaborator

@ayanray089 ayanray089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tbulding tbulding self-requested a review August 27, 2024 23:46
@tbulding tbulding dismissed aws-ia-automator-prod[bot]’s stale review August 27, 2024 23:49

Aprovals have been granted.

@tbulding tbulding merged commit acbbea3 into main Aug 27, 2024
3 checks passed
@wellsiau-aws wellsiau-aws deleted the v0.0.1 branch September 7, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants