-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.0.1 #3
Conversation
Hi there, I am commenting because your project has not yet been published and you have opened a pr to the If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
If you require more information please reach out to your AWS contact assisting you with this project. |
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests completed successfully
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run task Terrraform plan analyzer
@@ -10,12 +10,19 @@ Integrate Amazon Bedrock to your HashiCorp Cloud Platform Terraform (Terraform C | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to include the term Agentic here because we're using that on our landing pages
@@ -29,6 +36,7 @@ Please refer to the [best-practice](#best-practice) section below for more detai | |||
To use this module you need have the following: | |||
|
|||
1. AWS account and credentials | |||
1. Amazon Bedrock model access (default model is `Claude 3 Sonnet`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also mention, lamdba, cloudfront and WAF access as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!, couple of minor nit picks
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests completed successfully
/confirm-publication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review has been requested from required contributors, once they have approved I will remove my request for changes. When this PR is merged your project will be published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Aprovals have been granted.
Candidate release v0.0.1