Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor & e2e test #2

Merged
merged 19 commits into from
Aug 26, 2024
Merged

feat: refactor & e2e test #2

merged 19 commits into from
Aug 26, 2024

Conversation

wellsiau-aws
Copy link
Collaborator

@wellsiau-aws wellsiau-aws commented Aug 26, 2024

Various code refactor and tidy up

Update function URL to use CloudFront OAC + signed payload

Terraform test

Copy link

Hi there,

I am commenting because your project has not yet been published and you have opened a pr to the main branch.

If you are ready to publish, please issue the following comment on this PR and I will initiate the publication review
process:

/confirm-publication

If you require more information please reach out to your AWS contact assisting you with this project.

@wellsiau-aws wellsiau-aws self-assigned this Aug 26, 2024
@wellsiau-aws wellsiau-aws added the enhancement New feature or request label Aug 26, 2024
@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.

@wellsiau-aws
Copy link
Collaborator Author

Terraform test runs successfully but failed to delete the Lambda@Edge. Researching.

@wellsiau-aws
Copy link
Collaborator Author

/do-e2e-tests

Copy link

End to end test has been scheduled

Copy link

E2E tests in progress

Copy link

@aws-ia-automator-prod aws-ia-automator-prod bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests completed successfully

Copy link
Collaborator

@gautambaghel gautambaghel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1,9 +1,29 @@
# terraform-aws-plan-analyzer-runtask
# Runtask Terraform Plan Analyzer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wellsiau-aws let's rename to Terraform run task plan analyzer

Use this module to develop HCP Terraform run task and deploy it in AWS.
## Overview

Integrate Amazon Bedrock to your HashiCorp Cloud Platform Terraform (Terraform Cloud) Run Tasks for:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prev. Terraform Cloud and "run tasks" start with small letters

@@ -1,10 +1,14 @@
# Usage Example

This is a basic example setup on using the module.
Follow the steps below to deploy the module and attach it to your Terraform Cloud organization.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HCP Terraform organization

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

from tools.get_ami_releases import GetECSAmisReleases

# Initialize model_id and region
model_id = "anthropic.claude-3-sonnet-20240229-v1:0"
aws_region = "us-west-2"
default_model_id = "anthropic.claude-3-sonnet-20240229-v1:0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

Copy link
Collaborator

@ayanray089 ayanray089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes

@wellsiau-aws wellsiau-aws merged commit 7d08228 into main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants